-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui, server): Generic SSO OAuth2 OpenID Connect #188
Open
DelaunayAlex
wants to merge
26
commits into
main
Choose a base branch
from
feat/sso_oauth2_oidc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+949
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelaunayAlex
force-pushed
the
feat/sso_oauth2_oidc
branch
from
October 10, 2024 14:58
8dfc0dd
to
9eaab03
Compare
nbrouand
reviewed
Oct 14, 2024
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/api/SsoOpenIdConnectController.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/chutneytesting/security/infra/sso/OAuth2SsoSecurityConfiguration.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/infra/sso/OAuth2SsoUserService.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/infra/sso/SsoOpenIdConnectConfig.java
Outdated
Show resolved
Hide resolved
KarimGl
reviewed
Oct 15, 2024
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
chutney/packaging/local-dev/src/main/resources/application-sso-auth.yml
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/api/SsoOpenIdConnectController.java
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/api/SsoOpenIdConnectController.java
Outdated
Show resolved
Hide resolved
...ey/server/src/main/java/com/chutneytesting/security/infra/sso/OAuth2AuthenticationToken.java
Show resolved
Hide resolved
...rver/src/main/java/com/chutneytesting/security/infra/sso/OAuth2SsoSecurityConfiguration.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/chutneytesting/security/infra/sso/OAuth2SsoSecurityConfiguration.java
Outdated
Show resolved
Hide resolved
KarimGl
reviewed
Oct 16, 2024
...ver/src/main/java/com/chutneytesting/security/infra/sso/OAuth2TokenAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
chutney/ui/src/app/core/services/sso-open-id-connect.service.ts
Outdated
Show resolved
Hide resolved
DelaunayAlex
force-pushed
the
feat/sso_oauth2_oidc
branch
2 times, most recently
from
October 21, 2024 16:14
515489c
to
a9c606c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
============================================
- Coverage 61.19% 61.09% -0.10%
- Complexity 3408 3420 +12
============================================
Files 668 675 +7
Lines 18445 18578 +133
Branches 1008 1016 +8
============================================
+ Hits 11287 11350 +63
- Misses 6745 6820 +75
+ Partials 413 408 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
My view on this :
I'll add some associated comments directly on the files. |
chutney/packaging/local-dev/src/main/resources/application-sso-auth.yml
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/AbstractChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/api/SsoOpenIdConnectController.java
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/domain/SsoOpenIdConnectConfig.java
Outdated
Show resolved
Hide resolved
...y/server/src/main/java/com/chutneytesting/security/domain/SsoOpenIdConnectConfigService.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/domain/SsoOpenIdConnectMapper.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/chutneytesting/security/infra/sso/OAuth2SsoSecurityConfiguration.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/chutneytesting/security/infra/sso/OAuth2SsoSecurityConfiguration.java
Outdated
Show resolved
Hide resolved
DelaunayAlex
force-pushed
the
feat/sso_oauth2_oidc
branch
2 times, most recently
from
October 30, 2024 10:41
57b2d12
to
1b2cc87
Compare
KarimGl
reviewed
Nov 18, 2024
chutney/server/src/main/java/com/chutneytesting/security/api/SsoOpenIdConnectConfigDto.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/chutneytesting/security/infra/sso/SsoOpenIdConnectConfigProperties.java
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/api/SsoOpenIdConnectController.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/api/SsoOpenIdConnectMapper.java
Outdated
Show resolved
Hide resolved
…O Opaque token and generate session on server side
…O Opaque token and generate session on server side
DelaunayAlex
force-pushed
the
feat/sso_oauth2_oidc
branch
from
November 19, 2024 15:48
95c3066
to
33c2a05
Compare
nbrouand
reviewed
Nov 19, 2024
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
chutney/server/src/main/java/com/chutneytesting/security/ChutneyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.