Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui, server): Generic SSO OAuth2 OpenID Connect #188

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

DelaunayAlex
Copy link
Contributor

No description provided.

@DelaunayAlex DelaunayAlex added the enhancement New feature or request label Oct 1, 2024
@DelaunayAlex DelaunayAlex marked this pull request as draft October 1, 2024 06:43
@boddissattva boddissattva marked this pull request as ready for review October 21, 2024 07:31
@DelaunayAlex DelaunayAlex force-pushed the feat/sso_oauth2_oidc branch 2 times, most recently from 515489c to a9c606c Compare October 21, 2024 16:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 75 lines in your changes missing coverage. Please review.

Project coverage is 61.09%. Comparing base (42bc2bc) to head (5a38e60).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...sting/security/infra/sso/OAuth2SsoUserService.java 0.00% 18 Missing ⚠️
...ity/infra/sso/OAuth2TokenAuthenticationFilter.java 0.00% 17 Missing ⚠️
...tneytesting/security/ChutneyWebSecurityConfig.java 25.00% 14 Missing and 1 partial ⚠️
...y/infra/sso/OAuth2TokenAuthenticationProvider.java 0.00% 13 Missing ⚠️
.../security/infra/sso/OAuth2AuthenticationToken.java 0.00% 6 Missing ⚠️
...eytesting/security/api/SsoOpenIdConnectMapper.java 0.00% 4 Missing ⚠️
...esting/security/api/SsoOpenIdConnectConfigDto.java 0.00% 1 Missing ⚠️
...sting/security/api/SsoOpenIdConnectController.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #188      +/-   ##
============================================
- Coverage     61.19%   61.09%   -0.10%     
- Complexity     3408     3420      +12     
============================================
  Files           668      675       +7     
  Lines         18445    18578     +133     
  Branches       1008     1016       +8     
============================================
+ Hits          11287    11350      +63     
- Misses         6745     6820      +75     
+ Partials        413      408       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DelaunayAlex DelaunayAlex self-assigned this Oct 24, 2024
@boddissattva
Copy link
Member

My view on this :

  • I want to have a working app even if the sso provider is not here. For the moment, backend does not start (but you only have to comment the issuer-id) and the frontend has error too (maybe include the sso controller in the sso profile and catch an error in client in order to deactivate the sso service).
  • The sso test package should be in local-dev test directory i think.
  • Is it possible to have the profile sso to be additive ? i.e. to be more like ldap or other, just add some independant configuration with no consequence on the existing conf (i talk here about the web security filter chain).
  • I don't understand why some sso classes are in the domain ?

I'll add some associated comments directly on the files.

@DelaunayAlex DelaunayAlex force-pushed the feat/sso_oauth2_oidc branch 2 times, most recently from 57b2d12 to 1b2cc87 Compare October 30, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants