Fix handling of indicators in plain scalars to conform to YAML 1.2 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAML 1.2 has special handling of indicators to be compatible with JSON.
The following is equivalent to `{"a": "b"}` (note, no space after `:`):
{"a":b}
But without the quoted key, a space is required. So the `:` here is part
of the plain scalar:
{a:b} # == {"a:b"}
A plain scalar can also start with a `:` as long as it's followed by
"safe" characters:
{a: :b} # == {"a": ":b"}
(Fixes chyh1990#118)
robinst
force-pushed
the
fix-handling-of-indicators-in-plain-scalar
branch
from
15cea01 to
a5c17a2
Compare
|
@chyh1990 saw that you merged the rustfmt PR :)! Rebased this one and it now has a green build too. |
|
@chyh1990 Yay :). Are you planning to cut a release with this fix soon? |
|
v0.4.3 has been released on Github & crates.io |
robinst
added a commit
to trishume/syntect
that referenced
this pull request
Mar 24, 2019
Needs a newer yaml-rust to get this fix: chyh1990/yaml-rust#122 There are currently test failures and more syntests are failing than before. Needs to be investigated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML 1.2 has special handling of indicators to be compatible with JSON.
The following is equivalent to
{"a": "b"}(note, no space after:):But without the quoted key, a space is required. So the
:here is partof the plain scalar:
A plain scalar can also start with a
:as long as it's followed by"safe" characters:
(Fixes #118)
(See #116 for failing build)