Handle multiple params of the same name properly #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we try to call consumer.get('URL?param=1¶m=2'), the library
generates incorrect URL. That is because it internally parses the URL so
that the params are actually called 'param[0]' and 'param[1]'.
This patch fixed the param names so that the resulting URL is actually
including 'param=1' and 'param=2'.
|
Works for me. Tks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we try to call
consumer.get('URL?param=1¶m=2'), the librarygenerates incorrect URL. That is because it internally parses the URL so
that the params are actually called
param[0]andparam[1].This patch fixed the param names so that the resulting URL is actually
including
param=1andparam=2.This is what was proposed in #71 and it fixes #71 .