Add underlying http request agent configuration support to oauth2 #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an great solution and would help me out with an issue I faced with self signed certificates. Please merge! |
|
This helped me out too! Please merge! |
|
When will this PR be merged? I am facing similar issue. |
|
I don't quite understand, why doesn't 6baf574 satisfy your requirements? |
|
@kulkame you may want to try submitting a patch against my fork: https://github.com/omouse/node-oauth-libre I merged a similar patch many months ago (related to Authorization header for oauth2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced an issue where we needed to adjust http request agent configurations but could not find anyway of configuring passport oauth2 to propagate those configurations to the underlying library. This PR should resolve that issue in a generic way that is hopefully applicable to future use cases as well.
Similar issue reported #329