-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs & ci config for latest docker engine #38
update docs & ci config for latest docker engine #38
Conversation
References #36 |
Thanks for the contribution! @codevbus
|
@asi-cider - Thanks for taking a look! I'll get CircleCI set up; that should give me some feedback on the changes. Re: manual Docker installation: You are correct, it does look like the included package for I'll update the instructions to distinguish between users who have the latest Docker Desktop versus users who might want to install on a fresh server instance. |
2ce9968
to
d5de1cd
Compare
@asi-cider - Hello! Apologies for the delay. I got circleCI running, but am encountering this error: Are you seeing this upstream? Do you want me to fix it? |
Hey @codevbus, I fixed this few days ago, you can merge the main branch into yours and it'll solve this Thanks! |
@codevbus |
da929a8
to
29c5f18
Compare
compatible with Compose v2 remove manual docker install steps from ci add readme callout for docker desktop remove all explicit install steps for Docker depend on image for systemctl upgrade ubuntu image to 22.04 w. newer compose fix image syntax fix image name syntax
29c5f18
to
e00c25a
Compare
@asi-cider
Looks like the newer image has a newer python version than some of the constraints are expecting: https://circleci.com/api/v1.1/project/github/codevbus/cicd-goat/8/output/107/0?file=true&allocation-id=632156e84de91b2678cc507c-0-build%2F2ANITVV4 For the steps, I was getting inconsistent behavior running the commands all at once, I figured an explicit step was better. Can definitely change it back. Should I go back to the previous image version with the explicit plugin install? |
@codevbus |
Adds compatibility with newer Docker and Docker Compose pattern.