grdi export one health enterics #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Needs testing
ivansg44
commented
Aug 22, 2024
| * return ""; | ||
| * } | ||
| * ``` | ||
| * TODO is there any need for additional complexities in getMappedField? |
There was a problem hiding this comment.
@ddooley I am just copy-pasting vals for the most part (with the exception of some trimming I also need advice on below)
ivansg44
commented
Aug 22, 2024
| ); | ||
| const valsToCheck = headerNamesToCheck.map((headerName) => { | ||
| const valToCheck = inputRow[sourceFieldNameMap[headerName]]; | ||
| // TODO trim because copy pasting from excel == '\r\n'; wider issue? |
ivansg44
commented
Aug 22, 2024
web/templates/grdi/export.js
Outdated
| @@ -73,6 +73,7 @@ export default { | |||
| // ['gene_name_2', []], | |||
| // ['diagnostic_PCR_CT_value_2', []], | |||
| // ['description',[]], | |||
| // TODO there are additional fields now; what order? | |||
There was a problem hiding this comment.
@ddooley Does the existing biosample need to be updated too?
ivansg44
commented
Aug 22, 2024
web/templates/grdi/export.js
Outdated
| @@ -104,4 +105,397 @@ export default { | |||
| return outputMatrix; | |||
| }, | |||
| }, | |||
|
|
|||
| // TODO I see other refs to NCBI_BioSample in project; good name? | |||
|
I should go through and test everything once more |
* Also update schema
* Need to update enums
* Remove obsolete mapping obj
ivansg44
commented
Oct 8, 2024
| let atLeastOneWideVal = false; | ||
| for (const [i, longHeader] of longHeadersArr.entries()) { | ||
| let wideHeader = antibiotic.concat('_', longHeader); | ||
| if (longHeader === 'vendor') wideHeader += '_name'; |
ivansg44
commented
Oct 8, 2024
| outputMatrix.push(longRow); | ||
| } | ||
| } | ||
| // Ensures a row is still added if no antibiotic info is present |
There was a problem hiding this comment.
Is this necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.