Sanitize the autodetected cluster name #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
force-pushed
the
pr/giorio94/main/cluster-name-validation
branch
from
36f43d2
to
cd2369f
Compare
giorio94
force-pushed
the
pr/giorio94/main/cluster-name-validation
branch
from
cb3e912
to
c5eccc3
Compare
giorio94
requested review from
sayboras,
doniacld,
derailed and
viktor-kurchenko
giorio94
changed the title
sayboras
approved these changes
Jun 12, 2024
derailed
approved these changes
Jun 12, 2024
giorio94
force-pushed
the
pr/giorio94/main/cluster-name-validation
branch
from
c5eccc3
to
6a3e6a1
Compare
|
Let me try dropping the commit which bumps the cilium dependency, to see if the CI failures resolve (as they cannot be possibly caused by the other changes). That also leads to dropping the extra validation, which I'll add back in a separate PR. |
giorio94
changed the title
Instead of using the cluster name parameter, which could be different on upgrade (e.g., if the user previously specified a different name), or mutated in case it does not match the expected format. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Replace underscores and dots with dashes, as they are not allowed characters for cluster names. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Dots are not allowed as part of the cluster name. Let's fix the kind workflow to only configure valid cluster names. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/cluster-name-validation
branch
from
6a3e6a1
to
93455c8
Compare
|
@doniacld Gentle ping 🙏 |
|
@doniacld Gentle ping 🙏 |
doniacld
approved these changes
Jun 25, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace underscores and dots with dashes, as they are not allowed characters for cluster names.
Additionally perform the same validation already implemented by the latest Cilium version, to exit early and provide a helpful message in case of errors.Edit. I've removed these changes as bumping the Cilium dependency seems to cause a couple of tests to fail quite consistently.
(The large diff count is caused by bumping the Cilium dependency to the current main, to reuse the already available validation function. Please review commit by commit)