[Connectivity] Refactor single node detection #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a dedicated function for detecting if the cluster under test is comprised of a single node. Two improvements are made in this dedicated functions: 1. Detect the newer node-role.kubernetes.io/control-plane taint which replaces the master role 2. Explicitly check for the 'NoSchedule' effect of a discovered taint. A subsequent commit will remove single node detection from initClient and invoke this new method during connectivity test setup and validation. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
Refactor ConnectivityTest.initClients function to no longer detect single node clusters. The method's sole responsibility is now setting the ConnectivityTest's k8s clients. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
ldelossa
force-pushed
the
ldelossa/use-control-plane-taint
branch
from
4f91f12
to
9552f37
Compare
christarazi
approved these changes
Jun 24, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the single node detection.
Primarily, we now look for the newer
node-role.kubernetes.io/control-planetaint along with explicitly examining the taint's effect to ensure it is "NoSchedule".