Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ExternalTargetCANamespace name #2637

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

viktor-kurchenko
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko commented Jun 26, 2024

The fix for connectivity tests ExternalTargetCANamespace name.
The name must be namespace specific in case of tests
concurrent run for proper CiliumNetworkPolicy provisioning.

  • GKE workflow
  • AKS BYOCNI workflow
  • External workloads workflow
  • EKS tunnel workflow failed (not enough resources for test-concurrency=5)
  • EKS ENI workflow failed (not enough resources for test-concurrency=5)
  • Multicluster workflow failed (looks like not related to test-concurrency param)

Fix: #2644

@viktor-kurchenko viktor-kurchenko changed the title Pr/vk/external/ns/fix fix: ExternalTargetCANamespace name Jun 26, 2024
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice good catch! 😍

@michi-covalent
Copy link
Contributor

kind failure might be legitimate. i see a similar set of tests failing consistently 💭

❌ 1/13 tests failed (0/85 actions), 5 tests skipped, 0 scenarios skipped:
Test [dns-only]:

📋 Test Report [test-namespace-2]
❌ 1/11 tests failed (0/133 actions), 5 tests skipped, 0 scenarios skipped:
Test [client-egress-l7-tls-deny-without-headers]:

📋 Test Report [test-namespace-3]
❌ 1/12 tests failed (0/83 actions), 4 tests skipped, 0 scenarios skipped:
Test [client-egress-l7-tls-headers]:

📋 Test Report [test-namespace-4]
❌ 1/11 tests failed (0/93 actions), 4 tests skipped, 0 scenarios skipped:
Test [client-egress-l7-set-header]:

@viktor-kurchenko
Copy link
Contributor Author

kind failure might be legitimate. i see a similar set of tests failing consistently 💭

Oh, no... I'll take a look! Thanks!

The fix for connectivity tests ExternalTargetCANamespace name.
The name must be namespace specific in case of tests
concurrent run for proper CiliumNetworkPolicy provisioning.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko
Copy link
Contributor Author

@michi-covalent it should work now.

@michi-covalent
Copy link
Contributor

let me rebase to pick up the multicluster fix

@michi-covalent michi-covalent merged commit a2cb73e into main Jun 26, 2024
15 checks passed
@michi-covalent michi-covalent deleted the pr/vk/external/ns/fix branch June 26, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: speedup workflows with test concurrency flag
2 participants