Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: Couple of changes to support Ingress/CEC/CCWEC #825

Merged
merged 5 commits into from
May 4, 2022

Conversation

sayboras
Copy link
Member

Description

Please refer individual commit for more details

Testing

Testing was done locally to make sure nothing break.

@sayboras sayboras requested a review from a team as a code owner April 30, 2022 09:23
@sayboras sayboras requested a review from a team April 30, 2022 09:23
@sayboras sayboras requested a review from a team as a code owner April 30, 2022 09:23
@sayboras sayboras requested review from rolinh and nathanjsweet April 30, 2022 09:23
@sayboras sayboras temporarily deployed to ci April 30, 2022 09:23 Inactive
@sayboras sayboras force-pushed the tam/cilium-ingress branch from 4468337 to eb1c7a2 Compare April 30, 2022 11:16
@sayboras sayboras temporarily deployed to ci April 30, 2022 11:17 Inactive
@sayboras
Copy link
Member Author

hit this #816 when compiling for windows.

@sayboras sayboras force-pushed the tam/cilium-ingress branch from eb1c7a2 to 8bc96e3 Compare May 1, 2022 04:36
@sayboras sayboras temporarily deployed to ci May 1, 2022 04:36 Inactive
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@sayboras sayboras force-pushed the tam/cilium-ingress branch from b827ee4 to 882ddd9 Compare May 2, 2022 10:45
@sayboras sayboras temporarily deployed to ci May 2, 2022 10:45 Inactive
@sayboras sayboras force-pushed the tam/cilium-ingress branch from 882ddd9 to 607c439 Compare May 2, 2022 10:55
@sayboras sayboras force-pushed the tam/cilium-ingress branch from 607c439 to 0e6eb19 Compare May 2, 2022 10:57
@sayboras sayboras temporarily deployed to ci May 2, 2022 10:57 Inactive
@sayboras sayboras added the dont-merge/blocked Another PR must be merged before this one. label May 2, 2022
@sayboras sayboras force-pushed the tam/cilium-ingress branch from 0e6eb19 to 5999f54 Compare May 2, 2022 11:28
@sayboras sayboras temporarily deployed to ci May 2, 2022 11:28 Inactive
@sayboras sayboras force-pushed the tam/cilium-ingress branch from 5999f54 to cdf67dd Compare May 2, 2022 15:24
@sayboras sayboras temporarily deployed to ci May 2, 2022 15:24 Inactive
@sayboras sayboras removed the dont-merge/blocked Another PR must be merged before this one. label May 2, 2022
@sayboras sayboras force-pushed the tam/cilium-ingress branch from cdf67dd to 534a2a1 Compare May 3, 2022 02:44
@sayboras sayboras temporarily deployed to ci May 3, 2022 02:44 Inactive
@sayboras sayboras force-pushed the tam/cilium-ingress branch from 534a2a1 to ff9b61d Compare May 3, 2022 02:56
@sayboras sayboras temporarily deployed to ci May 3, 2022 02:56 Inactive
@sayboras
Copy link
Member Author

sayboras commented May 3, 2022

Sorry for all the noises, I was struggling with go.sum mismatch between local and CI 😓 , it should be fine now.

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯 LGTM apart from a few small nits.

sysdump/sysdump_test.go Outdated Show resolved Hide resolved
sysdump/sysdump.go Outdated Show resolved Hide resolved
sysdump/sysdump.go Outdated Show resolved Hide resolved
sysdump/sysdump.go Outdated Show resolved Hide resolved
install/uninstall.go Outdated Show resolved Hide resolved
@sayboras sayboras force-pushed the tam/cilium-ingress branch from ff9b61d to a603f14 Compare May 3, 2022 09:05
@sayboras sayboras force-pushed the tam/cilium-ingress branch from a603f14 to 4fe01d4 Compare May 3, 2022 09:06
@sayboras sayboras temporarily deployed to ci May 3, 2022 09:06 Inactive
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tam!

sayboras added 5 commits May 3, 2022 23:05
Helm template output is already having this namespace manifest.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to create role and role binding resources for both agent and
operator.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
The goal is to have new CRDs (e.g. CiliumEnvoyConfig and,
CiliumClusterwideEnvoyConfig), which will be used in subsequent commits.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to make sure that envoy proto types are registered.

```
level=warning msg="Ignoring invalid CiliumEnvoyConfig JSON (proto: (line 1:10): unable to resolve \"type.googleapis.com/envoy.config.listener.v3.Listener\": \"not found\"): {\n\t\"@type\": \"type.googleapis.com/envoy.config.listener.v3.Listener\",\n\t\"filterChains\": ...
```

Signed-off-by: Tam Mach <tam.mach@cilium.io>
This commit is to add support for 3 new resources Ingress, CCEC and CEV.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the tam/cilium-ingress branch from 72603b3 to 96ee17c Compare May 3, 2022 13:05
@sayboras sayboras temporarily deployed to ci May 3, 2022 13:06 Inactive
@michi-covalent michi-covalent merged commit e11e159 into master May 4, 2022
@michi-covalent michi-covalent deleted the tam/cilium-ingress branch May 4, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants