Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Document enable-node-selector-labels flag #31188

Merged
merged 1 commit into from
Jun 21, 2024
Merged

docs: Document enable-node-selector-labels flag #31188

merged 1 commit into from
Jun 21, 2024

Conversation

oblazek
Copy link
Contributor

@oblazek oblazek commented Mar 6, 2024

As the feature #26924 has been merged, adding a documentation.

Signed-off-by: Ondrej Blazek ondrej.blazek@firma.seznam.cz

docs: Document enable-node-selector-labels flag

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 6, 2024
@oblazek oblazek force-pushed the ob-node-selector-labels-docs branch from 4c9685e to 56bbee8 Compare April 4, 2024 09:57
@oblazek oblazek mentioned this pull request Apr 12, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label May 5, 2024
@oblazek
Copy link
Contributor Author

oblazek commented May 6, 2024

Not stale, still working on how to make the "Check generated documentation" pass.

@oblazek oblazek force-pushed the ob-node-selector-labels-docs branch from 56bbee8 to 30eb675 Compare May 6, 2024 05:40
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label May 7, 2024
@oblazek
Copy link
Contributor Author

oblazek commented May 21, 2024

this is depending on #31924

@oblazek oblazek force-pushed the ob-node-selector-labels-docs branch from 30eb675 to 4b386cf Compare May 21, 2024 12:11
@oblazek oblazek force-pushed the ob-node-selector-labels-docs branch from 4b386cf to 9e3a8b9 Compare June 3, 2024 11:40
@oblazek
Copy link
Contributor Author

oblazek commented Jun 3, 2024

/test

@oblazek
Copy link
Contributor Author

oblazek commented Jun 3, 2024

hitting #32715

@oblazek
Copy link
Contributor Author

oblazek commented Jun 3, 2024

/ci-runtime

@oblazek
Copy link
Contributor Author

oblazek commented Jun 3, 2024

/ci-ginkgo

@oblazek
Copy link
Contributor Author

oblazek commented Jun 3, 2024

/ci-external-workloads

@oblazek oblazek marked this pull request as ready for review June 3, 2024 12:47
@oblazek oblazek requested review from a team as code owners June 3, 2024 12:47
@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Jun 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 4, 2024
@lambdanis lambdanis added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 4, 2024
@oblazek oblazek force-pushed the ob-node-selector-labels-docs branch from 9e3a8b9 to d4a2532 Compare June 6, 2024 05:03
@aanm aanm requested a review from lambdanis June 13, 2024 11:55
@oblazek oblazek force-pushed the ob-node-selector-labels-docs branch from d4a2532 to fb19f95 Compare June 14, 2024 05:39
lambdanis
lambdanis reviewed Jun 17, 2024
View reviewed changes
Documentation/security/policy/language.rst Outdated Show resolved Hide resolved
Documentation/security/policy/language.rst Outdated Show resolved Hide resolved
Documentation/security/policy/language.rst Outdated Show resolved Hide resolved
Documentation/security/policy/language.rst Show resolved Hide resolved
@oblazek
docs: Document enable-node-selector-labels flag
1303a70 
Signed-off-by: Ondrej Blazek <ondrej.blazek@firma.seznam.cz>
@oblazek oblazek force-pushed the ob-node-selector-labels-docs branch from fb19f95 to 1303a70 Compare June 19, 2024 06:54
@oblazek oblazek requested a review from lambdanis June 19, 2024 09:12
lambdanis
lambdanis approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

derailed
derailed approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oblazek Thank you for this update!

@lambdanis
Copy link
Contributor

/test

@joestringer joestringer added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. release-blocker/1.16 This issue will prevent the release of the next version of Cilium. labels Jun 21, 2024
@joestringer
Copy link
Member

joestringer commented Jun 21, 2024 •
edited
Loading

@oblazek I think this slipped off everyone's radar, but it seems worthwhile to get into the tree for v1.16. Could you rebase so we can re-run CI / merge?

I'm proposing this as a potential 1.16 blocker for end of July.

EDIT: Actually maybe we don't need a rebase, I saw the age of the PR and the CI failures, then I assumed the PR was a bit stale. I see now that you've recently pushed a fresh version, so rebase might not be necessary. The test failures also all appear to be unrelated to documentation changes, so they presumably are latent issues on main rather than being related to this PR.

@joestringer
Copy link
Member

Given the approvals and that the Documentation tests are passing, this looks good to merge. We can separately follow up on any CI instability in the main branch.

@joestringer joestringer merged commit 1cd4e54 into cilium:main Jun 21, 2024
55 of 66 checks passed
@joestringer joestringer mentioned this pull request Jun 21, 2024
Closed
@joestringer joestringer added the backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. label Jun 28, 2024
@joestringer joestringer mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@lambdanis lambdanis lambdanis approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. release-blocker/1.16 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
Release blockers
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oblazek @lambdanis @joestringer @derailed