bgpv2: use peer asn and address in the key #33263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
harsimran-pabla
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
harsimran-pabla
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
harsimran-pabla
added
release-note/bug
On updating peer ASN and address, we need to remove old peer and readd it again. This change adds ASN and address in the key of peer along with the name. Secondly, order of changing peer is now delete, update and add. This is done because adding before deleting old peer is going to fail when changing ASN. This change also allows setting local peer port to 0 (random port selection from kernel) Signed-off-by: harsimran pabla <hpabla@isovalent.com>
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/33163_v2
branch
from
192e50a
to
a8da066
Compare
|
/test |
1 similar comment
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
joestringer
added
the
backport-done/1.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ASN and address to the peer's key along with the name.
Secondly, the order of peer changes is now deleted, updated, and added. This is done because adding an old peer before deleting it will fail when changing the peer ASN or address.
This change also allows setting the local peer port to 0 (random port selection from the kernel). This is required when setting the local port from some value back to 0.
Fixes: #33163