Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hive: Fixed copy-paste error in reconciler.Metrics implementation #33374

Merged

Conversation

dylandreimerink
Copy link
Member

The code checked if IncrementalReconciliationTotalErrors was enabled but then modified IncrementalReconciliationCurrentErrors. Seems like a copy-paste error from the case above, fixed it.

The code checked if `IncrementalReconciliationTotalErrors` was enabled
but then modified `IncrementalReconciliationCurrentErrors`.
Seems like a copy-paste error from the case above, fixed it.

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
@dylandreimerink dylandreimerink added the release-note/misc This PR makes changes that have no direct user impact. label Jun 25, 2024
@dylandreimerink dylandreimerink marked this pull request as ready for review June 25, 2024 08:13
@dylandreimerink dylandreimerink requested a review from a team as a code owner June 25, 2024 08:13
@dylandreimerink
Copy link
Member Author

/test

Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 25, 2024
@dylandreimerink dylandreimerink added this pull request to the merge queue Jun 25, 2024
Merged via the queue into cilium:main with commit 1e4d3ae Jun 25, 2024
68 checks passed
@dylandreimerink dylandreimerink deleted the feature/fix-hive-error-metrics branch June 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants