Reduce binary size #554
Merged
Reduce binary size #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgraf
commented
Apr 15, 2017
tgraf
commented
Keeping this in the generic `common/types` blows the size of all users. Reduces size of cilium client from 45M to 37M. Signed-off-by: Thomas Graf <thomas@cilium.io>
Also: Including an entire package just to retrieve the definition of the ContainerName label is pointless as it will never ever change again. Size reduction: cilium 27M => 17M cilium-agent 37M => 37M cilium-docker 26M => 16M cilium-cni 26M => 16M Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
the
kind/enhancement
houndci-bot
reviewed
Apr 15, 2017
pkg/container/container.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| KubernetesContainerNameLabel = "io.kubernetes.container.name" |
There was a problem hiding this comment.
exported const KubernetesContainerNameLabel should have comment (or a comment on this block) or be unexported
aanm
approved these changes
Apr 15, 2017
michi-covalent
pushed a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
The multicluster workflow uses `go run` but doesn't explicitly install a specific Go version. Thus, in some cases an older Go version might be used which leads to failures such as: ``` vendor/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics.go:21:2: cannot find package "." in: /home/runner/work/cilium-cli/cilium-cli/vendor/io/fs ``` Fixes cilium#554 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.