Skip to content

Commit

Permalink
CI: remove errcheck linter
Browse files Browse the repository at this point in the history
The errcheck linter causes too many false positives to be useful.
For example, running the upstream errcheck binary flags a ton of
"unchecked" defer Close() calls which are probably filtered out
by golangci-lint.

As an appeal to authority, Cilium proper doesn't have errcheck
enabled either. And the author of the high quality staticcheck
has said that implementing errcheck without a high false positive
rate is not possible.

Just disable the linter.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
  • Loading branch information
lmb authored and ti-mo committed Oct 11, 2023
1 parent 167ebe6 commit 9f348bc
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ issues:
linters:
disable-all: true
enable:
- errcheck
- goimports
- gosimple
- govet
Expand All @@ -19,8 +18,3 @@ linters:
- typecheck
- unused
- gofmt

# Could be enabled later:
# - gocyclo
# - maligned
# - gosec

0 comments on commit 9f348bc

Please sign in to comment.