Skip to content

Commit

Permalink
CODEOWNERS: assign code ownership to florianl, mmat11 and dylandreime…
Browse files Browse the repository at this point in the history
…rink

As discussed at the Cilium Dev Summit 2024, this codifies review assignments
and expectations around interactivity on PR reviews.

Signed-off-by: Timo Beckers <timo@isovalent.com>
  • Loading branch information
ti-mo committed Mar 20, 2024
1 parent 42cbe8f commit baf13d1
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 14 deletions.
7 changes: 7 additions & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
* @cilium/ebpf-lib-maintainers

features/ @rgo3
link/ @mmat11

perf/ @florianl
ringbuf/ @florianl

btf/ @dylandreimerink
31 changes: 17 additions & 14 deletions docs/ebpf/contributing/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,31 +67,34 @@ from upstream kernel versions. You can update them to the latest version by:
Finally, bump the tested kernels in `.github/workflows/ci.yml`
## Project permissions
## Project Roles
If you'd like to contribute to the library more regularly, one of the
[maintainers][ebpf-lib-maintainers] can add you to the appropriate team or mark
you as a code owner. Please create an issue in the repository.
* [ebpf-go-contributors]
* Have ["Triage"][permissions] role
* May be asked to review certain parts of code
* May be asked to help with certain issues
* Have ["Triage"][permissions] role
* May be asked to review certain parts of code
* May be asked to help with certain issues
* [ebpf-go-reviewers]
* Have ["Write"][permissions] role
* CODEOWNER of a part of the code base
* In-depth review of code, escalates to maintainers if necessary
* Have ["Write"][permissions] role
* CODEOWNER of a part of the code base
* In-depth review of code, escalates to maintainers if necessary
- For bugfixes: review within 1-2 days
- Otherwise: review within a work week
- When lacking time: escalate to maintainers, but don’t ignore
* [ebpf-lib-maintainers]
* Have ["Admin"][permissions] role
* Manage releases
* Triage incoming issues and discussions
* Maintain CI & project permissions
* Maintain roadmap and encourage contributions towards it
* Merge approved PRs
* Have ["Admin"][permissions] role
* Manage releases
* Triage incoming issues and discussions and pull in CODEOWNERS if needed
* Maintain CI & project permissions
* Maintain roadmap and encourage contributions towards it
* Merge approved PRs
[virtme]: https://github.com/amluto/virtme
[run-tests.sh]: https://github.com/cilium/ebpf/blob/main/run-tests.sh
[permissions]: https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#permissions-for-each-role
[ebpf-go-contributors]: https://github.com/orgs/cilium/teams/ebpf-go-contributors/members
[ebpf-go-reviewers]: https://github.com/orgs/cilium/teams/ebpf-go-reviewers/members
[ebpf-lib-maintainers]: https://github.com/orgs/cilium/teams/ebpf-lib-maintainers/members
[ebpf-lib-maintainers]: https://github.com/orgs/cilium/teams/ebpf-lib-maintainers/members

0 comments on commit baf13d1

Please sign in to comment.