Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info: make it harder to add backwards incompatible API #1515

Merged
merged 1 commit into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions info.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,23 @@ import (
"github.com/cilium/ebpf/internal/unix"
)

// The *Info structs expose metadata about a program or map. Most
// fields are exposed via a getter:
//
// func (*MapInfo) ID() (MapID, bool)
//
// This is because the metadata available changes based on kernel version.
// The second boolean return value indicates whether a particular field is
// available on the current kernel.
//
// Always add new metadata as such a getter, unless you can somehow get the
// value of the field on all supported kernels. Also document which version
// a particular field first appeared in.
//
// Some metadata is a buffer which needs additional parsing. In this case,
// store the undecoded data in the Info struct and provide a getter which
// decodes it when necessary. See ProgramInfo.Instructions for an example.

// MapInfo describes a map.
type MapInfo struct {
Type MapType
Expand Down
33 changes: 33 additions & 0 deletions info_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"errors"
"fmt"
"os"
"reflect"
"strings"
"testing"

Expand Down Expand Up @@ -436,3 +437,35 @@ func TestProgInfoExtBTF(t *testing.T) {
}
}
}

func TestInfoExportedFields(t *testing.T) {
// It is highly unlikely that you should be adjusting the asserts below.
// See the comment at the top of info.go for more information.

var names []string
for _, field := range reflect.VisibleFields(reflect.TypeOf(MapInfo{})) {
if field.IsExported() {
names = append(names, field.Name)
}
}
qt.Assert(t, qt.ContentEquals(names, []string{
"Type",
"KeySize",
"ValueSize",
"MaxEntries",
"Flags",
"Name",
}))

names = nil
for _, field := range reflect.VisibleFields(reflect.TypeOf(ProgramInfo{})) {
if field.IsExported() {
names = append(names, field.Name)
}
}
qt.Assert(t, qt.ContentEquals(names, []string{
"Type",
"Tag",
"Name",
}))
}
Loading