Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map: remove misleading error message when creating without BTF #1522

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Jul 23, 2024

Time and time again people misunderstand errors like the following:

map create: cannot allocate memory (without BTF k/v)

Instead of focusing on the ENOMEM they assume that it has something to do with BTF. In reality it just means that creating a map has failed, and we didn't supply any BTF during creation.

Avoid this confusion by removing the "without BTF k/v" part.

Time and time again people misunderstand errors like the following:

    map create: cannot allocate memory (without BTF k/v)

Instead of focusing on the ENOMEM they assume that it has something
to do with BTF. In reality it just means that creating a map has
failed, and we didn't supply any BTF during creation.

Avoid this confusion by removing the "without BTF k/v" part.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb requested a review from a team as a code owner July 23, 2024 15:59
@lmb lmb merged commit 061e86d into cilium:main Jul 23, 2024
17 checks passed
@lmb lmb deleted the remove-btf-error branch July 23, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant