link,kprobe: add arch prefixes for portable syscall wrapper support #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
requested changes
May 17, 2021
lmb
reviewed
May 19, 2021
lmb
reviewed
May 19, 2021
ti-mo
requested changes
May 21, 2021
There was a problem hiding this comment.
Thanks for the patch! We're seeing arm being used more and more frequently, but I think this needs some more work in order to become useful.
- Please remove all merge commits.
git fetch origin && git rebase origin/masteris the way to keep your branch up-to-date with changes that have landed on master. - I don't feel like the additions to
CONTRIBUTING.mdare necessary. If we want to provide llvm builder images going forward,testdata/dockershould output images for both arm64 and x86, which will automatically be picked on hosts/dev machines of those respective architectures. link.K(ret)probeshould handle__x64_syscall fn prefixes transparently, but implementing this might be annoying given the difference between tracefs and PMU, see other comment on the code itself. Please reach out through Cilium Slack (#libbpf-go) if you need more input.
Marking this as draft in the mean time.
nickolaev
force-pushed
the
arm64
branch
2 times, most recently
from
d15407a
to
00b8c66
Compare
lmb
requested changes
May 28, 2021
There was a problem hiding this comment.
Please take a look at #304 (comment) which outlines a simpler API.
lmb
requested changes
Jun 7, 2021
ti-mo
reviewed
Jun 7, 2021
ti-mo
reviewed
Jun 7, 2021
ti-mo
reviewed
Jun 8, 2021
Add a basic developer support for ARM64, and possibly other non-x86 platforms. Make sure test are passing and the used syscalls are available on non-x86 hosts. Signed-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>
Signed-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>
Signed-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>
lmb
approved these changes
Jun 10, 2021
|
@nickolaev Thanks for the work! |
Closed
ti-mo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic developer support for ARM64, fixed the tests and added some instructions/notes.
Modify
kprobeto be smart about syscall naming, depending on the platform.For example, it will take
sys_getpidand turn it into__arm64_sys_getpidwhen running on an ARM64 host.Fixes #266
Signed-off-by: Nikolay Nikolaev nicknickolaev@gmail.com