btf: fix NewHandleFromID for kernel modules #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
kmod-split-btf
branch
2 times, most recently
from
b53e0ae to
430bc48
Compare
lmb
commented
Jul 7, 2022
Kernel modules only expose split BTF when queried via BPF_OBJ_GET_INFO_BY_FD. This causes NewHandleFromID to fail for kmod BTF, since the function attempts to inflate types. Avoid inflating types in NewHandleFromID and change Handle.Spec to accept a base Spec to allow decoding types from modules. This is a breaking change. Updates cilium#705
Add an iterator for BTF objects / handles. The API is the same as MapIterator. Used to test loading kmod split BTF from a BTF ID in a subsequent commit.
Use HandleIterator to find vmlinux and the first loaded module, and attempt to parse the split BTF. This requires exporting HandleInfo since we use external tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
btf: add split kmod BTF test
btf: add HandleIterator
btf: rename info.go to handle.go
btf: fix NewHandleFromID for kernel modules