Build, test and format with Go 1.19, minimum 1.18 #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
force-pushed
the
tb/go-1.19
branch
2 times, most recently
from
8dd84c5 to
fac5ae9
Compare
lmb
approved these changes
Aug 22, 2022
ti-mo
force-pushed
the
tb/go-1.19
branch
2 times, most recently
from
d9a259b to
a7d86d1
Compare
As we were not reaping the benefits from having a separate Go module for examples/, remove it to ease maintenance. Make examples buildable on GOOS=darwin by removing build tags and providing constants. This became necessary after removing the module for examples/, making those packages pop up in `go list`. Same for examples/uretprobe. This calls bpf2go with -target native, which only works when run on amd64 since other architectures are missing macros for getting syscall parameters. Gate the build of uretprobe behind an amd64 tag to prevent it from failing due to missing a corresponding generated bpf2go output .go file. Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Format output docstrings according to 1.19 convention in bpf2go. Signed-off-by: Timo Beckers <timo@isovalent.com>
Drop build tags from _fuzz.go as they're no longer required. Signed-off-by: Timo Beckers <timo@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.