Semaphore: remove manual Go installation, expedite 'cache restore' #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
force-pushed
the
tb/optimize-semaphore
branch
from
b7bbb31 to
d386846
Compare
'sem-version' apparently installs Go, so rely on it instead of isntalling Go manually. Execute 'cache restore' after 'checkout' (since it scans for go.mod), but before 'go install' to avoid tar errors unpacking the cache archive: ``` Unpacking command failed: tar: /home/semaphore/go/pkg/mod/github.com/jonboulle/clockwork@v0.2.2/.github/workflows/ci.yml: Cannot open: File exists tar: /home/semaphore/go/pkg/mod/github.com/jonboulle/clockwork@v0.2.2/.github/workflows/.editorconfig: Cannot open: File exists tar: /home/semaphore/go/pkg/mod/github.com/jonboulle/clockwork@v0.2.2/ticker.go: Cannot open: File exists ... ``` 'go install' does something that changes the ownership of go/pkg/mod, tripping up tar. Since 'go install' doesn't need to be run outside of a Go module like 'go get' did when using it to install tool binaries, it can safely be run after checkout. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/optimize-semaphore
branch
from
d386846 to
318ddc8
Compare
|
Semaphore is really slow in updating go versions unfortunately which is why that hack exists in the first place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recommendations from Semaphore support.
'sem-version' apparently installs Go, so rely on it instead of isntalling Go manually.
Execute 'cache restore' before 'go install' to avoid tar errors unpacking the cache archive: