map: export MapSpec.Compatible #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ultra-bikeshed: if m.CompatibleWith(spec) { ... }or even if m.Compatible(spec) { ... }? |
Please use i@lmb.io, I don't work at CF any more. |
|
Let me talk to timo, maybe we just make the original function public and leave it at that. |
|
I think exporting + renaming |
olsajiri
force-pushed
the
map_comp_check
branch
from
1e98d6d to
acf9f1f
Compare
Exporting MapSpec.checkCompatibility as MapSpec.Compatible Suggested-by: Lorenz Bauer <i@lmb.io> Suggested-by: Timo Beckers <timo@isovalent.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
lmb
approved these changes
Nov 23, 2022
lmb
changed the title
|
@olsajiri seems like your fork of the library has some changed tags, I get errors when trying to check out your PR via vscode. Maybe you could reset the fork? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding IsCompatibleWith function to export spec.checkCompatibility function.
Suggested-by: Lorenz Bauer lmb@cloudflare.com
Signed-off-by: Jiri Olsa jolsa@kernel.org