cs.RewriteConstants: define error MissingConstantsError #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RewriteConstants can return the error "spec is missing one or more
constants" if the constant given as parameter does not exist. This patch
defines the error as a specific type so it can be tested with:
var mErr *MissingConstantsError
if !errors.As(err, &mErr) { ... }
New unit tests are added, for both the success and failure cases.
Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Co-developed-by: Lorenz Bauer <oss@lmb.io>
lmb
force-pushed
the
alban_rewrite_constants
branch
from
acf61cc to
2124a4d
Compare
lmb
approved these changes
Jan 17, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RewriteConstants can return the error "spec is missing one or more constants" if the constant given as parameter does not exist. This patch defines the error as a specific type so it can be tested with:
New unit tests are added, for both the success and failure cases.
Tested with:
Signed-off-by: Alban Crequy albancrequy@linux.microsoft.com
This PR was suggested by @mauriciovasquezbernal in inspektor-gadget/inspektor-gadget#1201 (comment) to avoid testing with
Supersedes #902