enable e2e mode dynamically

cilium · Feb 21, 2024 · 956a2b8 · 956a2b8
1 parent fa148ac
commit 956a2b8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/.github/cilium-values.yaml b/.github/cilium-values.yaml
@@ -25,12 +25,6 @@ hubble:
           value: /var/log/hubble-ui-testing/log_files
         - name: CORS_ENABLED
           value: 'true'
-    frontend:
-      extraEnv:
-        - name: E2E_TEST_MODE
-          value: 'true'
-        - name: NODE_ENV
-          value: 'e2e'
     ingress:
       enabled: true
       className: nginx

diff --git a/src/index.tsx b/src/index.tsx
@@ -74,7 +74,7 @@ const run = async () => {
   app
     .onBeforeMount(_app => {
       const env = app.environment;
-      e2e.attributes.setEnabled(env.isDev || env.isTesting);
+      e2e.attributes.setEnabled(router.mockModeParam != null);
       uiLayer.onBeforeMount();
     })
     .onMounted(app => app.uiLayer.onMounted())

diff --git a/src/router/router.ts b/src/router/router.ts
@@ -74,6 +74,10 @@ export class Router extends EventEmitter<Handlers> {
     this.setupEventHandlers();
   }
 
+  public get mockModeParam() {
+    return this.searchParams.get('e2e');
+  }
+
   public get isInMemory() {
     return this.kind === RouterKind.Memory;
   }