Skip to content

Commit

Permalink
Remove wrong key lookup for service name in k8s labels
Browse files Browse the repository at this point in the history
Issue #792.
  • Loading branch information
yannikmesserli authored and geakstr committed Mar 21, 2024
1 parent 1ea1fd7 commit a0a0668
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions src/domain/__tests__/labels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,4 @@ describe('extract app name', () => {

appNameTest(['k8s:app.kubernetes.io/name=EXPECTED_NAME'], 'EXPECTED_NAME');
});

test('random label without explicit appName', () => {
appNameTest(['k8s:random-app=random-name'], 'random-name');
appNameTest(['k8s:random-name=random-app'], 'random-app');
});
});
1 change: 0 additions & 1 deletion src/domain/labels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export class Labels {
];

public static readonly appNameNormalizedKeys = new Set([
'component',
'app',
'name',
'functionname',
Expand Down

0 comments on commit a0a0668

Please sign in to comment.