Make Mutual Auth visible #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
This data is useful to send for a link to the UI to display info on if authentication happened as well as if encryption also is the case, Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
This will now fetch policy verdicts and show them in the table. By doing that it will also be able to display the authentication type if one is applied. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
This adds a green padlock from the icons font to the flow map. This will be added once an auth type was found in the flows. It will be colored green if (IPSec) encryptiion events also are found. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
geakstr
force-pushed
the
meyskens/auth-visibility
branch
from
4e063ee
to
37e05a8
Compare
Signed-off-by: Dima Kharitonov <geakstr@me.com>
geakstr
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to make Mutual Auth visible in the UI it does this by doing a few things:
How does it look?
Why should I NOT "ship it"
Welcome to the self-deprecating part of the code review process where I expose all my insecurities about this piece of code...
Part 1 the table: it currently only exposes auth type on policy verdicts which is not clearly visible, however this is more of an upstream issue IMO?
Part 2.1 the padlock shape: the simplest way (without doing all SVG path calculations in coded) to draw a padlock and maybe soon other icons or extra info was to use an SVG text element with icons font, this does create some loading overhead. Suggestions are welcome (especially in the form of a diff file)
part 2.2 the padlock position: why is it not next to the arrow? Yes true! That was my original intent but the positioning suddenly became way harder as well as the accessing of the relevant data where in the end connector it was available as we already show drops there. Suggestions are welcome (especially in the form of a diff file)
part 3 "ignoring all // TODOs found"": sorry out of scope...