-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UDP listener & proxy support #1066
Merged
Merged
+82
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mhofstetter
commented
Dec 17, 2024
•
edited
Loading
edited
sayboras
reviewed
Dec 18, 2024
sayboras
approved these changes
Dec 18, 2024
mhofstetter
force-pushed
the
pr/mhofstetter/udp-proxy
branch
from
December 18, 2024 19:36
4e2651f
to
bd183b5
Compare
This commit enables the UDP proxy related envoy extensions. * `UDPProxy` UDP listener filter * `HTTPCapsule` UDP session filter * `DynamicForwardProxy` UDP session filter Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Currently, configuring a UDP listener (Envoy listener with socket address protocol set to `udp`) with a UDPProxy in Envoy may fail due to Envoy failing to missing privileges to bind the listener address. The reason is that the Cilium Proxy uses a "starter" that drops all privileged capabilities before forking the actual Envoy process (See #315 for more details.) Setting up the necessary socket options is part of the Cilium `BPFMetadata` listener filter. The current `BPFMetadata` listener filter can't be used as UDP listener filter (different factory). Therefore, this commit introduces a UDP capable version of the `BPFMetadata` listener filter. It's only purpose is to setup the UDP listener socket correctly (IP_TRANSPARENT, SO_REUSEADDR, ...). It's currently NOT adding any BPF metadata related information to the socket. This is not necessary as the Cilium network filters aren't yet available for UDP either. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/udp-proxy
branch
from
December 19, 2024 07:35
bd183b5
to
f6b8495
Compare
mhofstetter
changed the title
extensions: enable udp proxy
Enable UDP listener & proxy support
Dec 19, 2024
jrajahalme
approved these changes
Dec 19, 2024
We might need to backport this to v1.31, as main branch is now with envoy v1.32. |
Thanks for the reminder Tam! #1070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.