Pipe event sink extension #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
force-pushed
the
pipe-event-sink-extension
branch
2 times, most recently
from
ac56093 to
c0dddca
Compare
sayboras
approved these changes
Sep 26, 2023
Factor out Unix domain socket client to a separate class UDSClient. Use C++ smart pointers instead of hand-rolled reference counting to manage the life-cycle of shared access loggers. Use Envoy::Network::Address::PipeInstance to gain support for Linux abstract namespace pipes. Do not fail Open if can't connect to the unix domain socket at the time of Open() so that connection is retried on every access log message hence. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
pipe-event-sink-extension
branch
from
c0dddca to
df73ce0
Compare
|
Resolved conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.