Fix format #379
Merged
Fix format #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "starter" and "vendor" to excluded directories for format check and fix. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Run 'make fix' to fix formatting issues. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
sayboras
approved these changes
Oct 10, 2023
Add a new format check workflow to CI. To run format check locally: - on docker: docker build --target=format -o out . - see results in: out/format-output.txt - last line should be "PASS" - command line: make check To fix format errors, run "make fix" locally. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
fix-format
branch
from
eb83b64 to
00f9049
Compare
|
Pushed small fix to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new format check workflow.
Add
starterandvendorto the list of excluded directories and applymake fix.This helps make future PRs cleaner by forcing "make fix" run before submitting PRs.