reconciler: Fix the prune total errors expvar

The example expvar metrics implementation incremented the total errors variable even when there wasn't an error. Signed-off-by: Jussi Maki <jussi.maki@isovalent.com>
cilium · Sep 6, 2024 · 574b83f · 574b83f
1 parent 2be89fe
commit 574b83f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/reconciler/example/main.go b/reconciler/example/main.go
@@ -169,6 +169,8 @@ func registerHTTPServer(
 
 	mux := http.NewServeMux()
 
+	// To dump the metrics:
+	// curl -s http://localhost:8080/expvar
 	mux.Handle("/expvar", expvar.Handler())
 
 	// For dumping the database:

diff --git a/reconciler/metrics.go b/reconciler/metrics.go
@@ -41,10 +41,10 @@ func (m *ExpVarMetrics) PruneDuration(moduleID cell.FullModuleID, duration time.
 
 func (m *ExpVarMetrics) PruneError(moduleID cell.FullModuleID, err error) {
 	m.PruneCountVar.Add(moduleID.String(), 1)
-	m.PruneTotalErrorsVar.Add(moduleID.String(), 1)
 
 	var intVar expvar.Int
 	if err != nil {
+		m.PruneTotalErrorsVar.Add(moduleID.String(), 1)
 		intVar.Set(1)
 	}
 	m.PruneCurrentErrorsVar.Set(moduleID.String(), &intVar)