Add support @TsNoCheck annotation, adds "// @ts-nocheck" to TypeScript #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript would complain about certain errors in the generated file. In some newer versions of TypeScript, an assert that is always true would not be permitted. We currently have two such asserts in our tests, which prevents us from upgrading the TypeScript version. Add support for a Java @tsnocheck annotation, which controls the inclusion of the corresponding TypeScript comment. While there is no mandatory package for the annotation, add it to jsweet.lang in core-lib. Fix tests to use the new annotation.
|
Thanks for contributing @kohlschuetter |
|
Merging broke the build because the core pom version wasn't updated. See #769, which unbreaks the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript would complain about certain errors in the generated file. In some newer versions of TypeScript, an assert that is always true would not be permitted.
We currently have two such asserts in our tests, which prevents us from upgrading the TypeScript version.
Add support for a Java @tsnocheck annotation, which controls the inclusion of the corresponding TypeScript comment. While there is no mandatory package for the annotation, add it to jsweet.lang in core-lib.
Fix tests to use the new annotation.