Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll tab target into view #1580

Merged
merged 1 commit into from
May 14, 2024
Merged

Scroll tab target into view #1580

merged 1 commit into from
May 14, 2024

Conversation

aceArt-GmbH
Copy link
Contributor

Description

Clicking a tab on mobile does not look very good.
Scroll the target into view (center) to see it clearly as well as following tabs

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@aceArt-GmbH
Copy link
Contributor Author

Rebased, still waiting on review

@github-actions GitHub Actions
Copy link

Preview: https://1580--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

ajbura
ajbura approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ajbura ajbura merged commit 97d02fd into cinnyapp:dev May 14, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
@aceArt-GmbH aceArt-GmbH deleted the tabScroll branch May 15, 2024 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajbura ajbura ajbura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aceArt-GmbH @ajbura