Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placement of emoji/sticker buttons #1693

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

agmm
Copy link
Contributor

@agmm agmm commented Apr 16, 2024

Description

Currently, the relative positions of the emoji and sticker buttons are not consistent with the relative positions of their respective badges. This PR addresses that inconsistency.

buttons-pr

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Apr 16, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@agmm
Copy link
Contributor Author

agmm commented Apr 16, 2024

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Apr 16, 2024
Copy link

@JuliaSoriaSmith JuliaSoriaSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is a simple swap. No concerns

Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes.

@ajbura ajbura merged commit 743e916 into cinnyapp:dev Apr 24, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants