Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 support for the Docker container #1884

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

utf-4096
Copy link
Contributor

Description

#1837 introduced a new NGINX config for Docker inspired by the existing contrib/nginx/cinny.domain.tld.conf, but without the listen [::]:80; directive, which breaks the container for those that use IPv6.

This PR adds the IPv4 and IPv6 listen directives to make it work on both again. (I also reformatted the file to follow the project's style).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Aug 11, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@utf-4096
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Aug 11, 2024
Copy link

github-actions bot commented Aug 11, 2024

Preview: https://1884--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@utf-4096 utf-4096 force-pushed the fix-docker-ipv6-support branch 2 times, most recently from 0526a39 to 1ad5b1e Compare August 20, 2024 17:08
Copy link
Collaborator

@kfiven kfiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@kfiven kfiven merged commit 5c9ee1a into cinnyapp:dev Aug 23, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
@utf-4096 utf-4096 deleted the fix-docker-ipv6-support branch August 23, 2024 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants