Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix media download #1947

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix media download #1947

merged 3 commits into from
Sep 11, 2024

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Sep 11, 2024 •
edited
Loading

Description

refactor media loading in timeline and download media prior to giving url to FileSaver

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions GitHub Actions
Copy link

Preview: https://1947--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

kfiven
kfiven approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@kfiven kfiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kfiven kfiven merged commit 03cc25e into dev Sep 11, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kfiven kfiven kfiven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajbura @kfiven