Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSC3244 use from restricted room creation #892

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

mjarr
Copy link
Contributor

@mjarr mjarr commented Oct 2, 2022

Description

Replaces preferred room version checking from rejected MSC3244 with in-client checks for restricted room creation. It also no longer hardcodes restricted rooms to room version 9.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://892--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Thanks!

@ajbura ajbura merged commit 6a907b1 into cinnyapp:dev Nov 1, 2022
@mjarr mjarr deleted the mjarr-patch-1 branch November 1, 2022 18:59
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
* Remove MSC3244 use from restricted room creation

* Fix condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants