This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
Backport to Rails 6 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshtonic
force-pushed
the
backport-to-rails-6
branch
9 times, most recently
from
66904db
to
e1eca99
Compare
mpalmer
approved these changes
May 13, 2022
freshtonic
force-pushed
the
backport-to-rails-6
branch
8 times, most recently
from
40567af
to
7420907
Compare
freshtonic
changed the title
RSpec assumes bugs are in the code under test (not its dependencies) so it hides a bunch of the backtrace by default. This changes ensures the full backtrace is exposed. When the client stabilises we can go back to the default.
freshtonic
force-pushed
the
backport-to-rails-6
branch
from
9dada95
to
8edd329
Compare
freshtonic
force-pushed
the
backport-to-rails-6
branch
2 times, most recently
from
9dada95
to
6594ddc
Compare
mpalmer
approved these changes
May 18, 2022
Comment on lines
+13
to
+16
| CS_WORKSPACE: ${{ secrets.CS_WORKSPACE }} | ||
| CS_KMS_KEY_ARN: ${{ secrets.CS_KMS_KEY_ARN }} | ||
| CS_NAMING_KEY: ${{ secrets.CS_NAMING_KEY }} |
There was a problem hiding this comment.
These aren't secrets, and putting them in as secrets makes it really difficult to "reverse engineer" what the action is doing.
There was a problem hiding this comment.
I'm going to merge as-is to get this PR landed.
I'm also not sure we really want those values as plain text in the repo even if they technically aren't secrets.
There was a problem hiding this comment.
If it turns out to be a problem we can fix it then
Detect Rails version in the railtie. If version < 6, bail hard. If version == 6, apply the monkey patch.
You can now provide an env var RSPEC_FULL_BACKTRACE if you need full backtraces. This is enabled in CI.
- pry not needed by default - rake and rspec moved to gemspec
freshtonic
force-pushed
the
backport-to-rails-6
branch
from
059ec8e
to
4f99cdf
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect Rails version in the railtie.
If version < 6, bail hard.
If version == 6, apply the monkey patch.