This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
DRY up before/after blocks in consistency spec #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshtonic
force-pushed
the
fix-remaining-flakiness
branch
from
39ee606
to
29c368b
Compare
mpalmer
approved these changes
May 23, 2022
| UserInconsistent.collection.drop! | ||
| UserInconsistent.collection.create! | ||
| expect { UserInconsistent.collection(true).info }.to_not raise_error | ||
| describe "when the backing collection exists but is missing an index" do |
There was a problem hiding this comment.
RSpec will automagically concatenate all the nested descriptions together to create the "full" description of a given test, so there's no need to duplicate "when the backing collection exists" in these subgroups.
There was a problem hiding this comment.
That's a copy pasta error - thanks!
freshtonic
added a commit
that referenced
this pull request
Dec 21, 2022
DRY up before/after blocks in consistency spec
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure what the semantics are of before/after with no-arg (just a
block) so I'm being explicit.