This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
Test against multiple ruby versions #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the ruby 2/3 keyword args fix in it.
mpalmer
approved these changes
May 25, 2022
| @@ -18,7 +18,7 @@ Gem::Specification.new do |spec| | |||
| spec.metadata["source_code_uri"] = "https://github.com/cipherstash/activestash" | |||
| spec.metadata["changelog_uri"] = "https://github.com/cipherstash/activestash/CHANGELOG.md" | |||
|
|
|||
| spec.add_runtime_dependency "cipherstash-client", ">= 0.10.2" | |||
| spec.add_runtime_dependency "cipherstash-client", ">= 0.10.4" | |||
There was a problem hiding this comment.
This is unnecessary -- bundler will automatically install the latest available version of a gem that otherwise meets the version constraints on the dependency.
There was a problem hiding this comment.
@mpalmer I tried a bundle install locally and it ... didn't.
There was a problem hiding this comment.
But the build is broken for Rubies < 0.10.4 so we should specify the minimum working version, right?
Co-authored-by: Matt Palmer <matt@cipherstash.com>
freshtonic
added a commit
that referenced
this pull request
Dec 21, 2022
…rsions Test against multiple ruby versions
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.