Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump circe to 0.11.0 #47

Merged
merged 3 commits into from
Jan 6, 2019
Merged

Bump circe to 0.11.0 #47

merged 3 commits into from
Jan 6, 2019

Conversation

BenFradet
Copy link
Collaborator

@BenFradet BenFradet commented Dec 24, 2018

supersedes #46

  • weird change of behavior:
scala> CirceSupportParser.async(AsyncParser.UnwrapArray)
res0: org.typelevel.jawn.AsyncParser[io.circe.Json] = org.typelevel.jawn.AsyncParser@3d718422

scala> .absorb("}")(CirceSupportParser.facade)
res1: Either[org.typelevel.jawn.ParseException,Seq[io.circe.Json]] = Right(ArrayBuffer())

Any ideas @travisbrown ?

  • previous circe version

@travisbrown
Copy link
Member

I opened an issue here, since it's a bug in Jawn 0.14.0. I'm not sure whether it should block this release?

@BenFradet
Copy link
Collaborator Author

Thanks, I'll modify the tests during the weekend and then we should be good to go release-wise 👍

@BenFradet
Copy link
Collaborator Author

@travisbrown should be good to go 👍

@codecov-io
Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #47 into master will decrease coverage by 4.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage     100%   95.83%   -4.17%     
==========================================
  Files           2        2              
  Lines          24       24              
==========================================
- Hits           24       23       -1     
- Misses          0        1       +1
Impacted Files Coverage Δ
src/main/scala/io/circe/fs2/package.scala 100% <ø> (ø) ⬆️
src/main/scala/io/circe/fs2/ParsingPipe.scala 85.71% <ø> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872bb5e...b5d40d4. Read the comment docs.

@travisbrown
Copy link
Member

👍, and I've got https://github.com/circe/circe-fs2/tree/travis/circe-0.11 lined up with the Jawn update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants