Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 bucket versioning as a requirement for DLC [ONPREM-1361] [server-4.6] #8874

Conversation

christian-stephen
Copy link
Member

Description

A brief description of the changes.

#8870

Reasons

A link to a GitHub and/or JIRA issue (if applicable).
Otherwise, a brief sentence about why you made these changes.

https://circleci.atlassian.net/browse/ONPREM-1361

Content Checklist

Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.

Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 😸:

  • Break up walls of text by adding paragraph breaks.
  • Consider if the content could benefit from more structure, such as lists or tables, to make it easier to consume.
  • Keep the title between 20 and 70 characters.
  • Consider whether the content would benefit from more subsections (h2-h6 headings) to make it easier to consume.
  • Check all headings h1-h6 are in sentence case (only first letter is capitalized).
  • Is there a "Next steps" section at the end of the page giving the reader a clear path to what to read next?
  • Include relevant backlinks to other CircleCI docs/pages.

@christian-stephen christian-stephen requested a review from a team July 23, 2024 10:32
@christian-stephen christian-stephen marked this pull request as ready for review July 23, 2024 10:34
@christian-stephen christian-stephen requested review from a team as code owners July 23, 2024 10:34
@christian-stephen christian-stephen merged commit 185e444 into DOCSS-1593-server-4.6 Jul 23, 2024
1 of 3 checks passed
rosieyohannan added a commit that referenced this pull request Aug 13, 2024
* create 4.6 branch using latest

* add to EN sidebar

* Add S3 bucket versioning as a requirement for DLC (#8874)

* Set aws_acm enable to true in server installation docs (#8877)

* Update Helm values for 4.6 (#8886)

* Noindex previous server docs (#8869)

* noindex all server pages not in `latest`

* Update images list for server 4.6 air-gap installs [ONPREM-1230] (#8889)

* Update images list for server 4.6 air-gap installs

* Update images list after testing and patching

* release notes

* fix lint errors

---------

Co-authored-by: Chris Stephen <chris.stephen@circleci.com>
Co-authored-by: Stuart Reid <stuart@circleci.com>
@rosieyohannan rosieyohannan deleted the ONPREM-1361/server-4.6/dlc-bucket-versioning branch September 5, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants