Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline permissions #9102

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Update pipeline permissions #9102

merged 3 commits into from
Nov 27, 2024

Conversation

BeFunes
Copy link
Contributor

@BeFunes BeFunes commented Nov 27, 2024

Description

  • Rename "config source" into "pipeline"
  • Updated permission grid to match prod (= contributors can't edit triggers or pipelines)

Reasons

A link to a GitHub and/or JIRA issue (if applicable).
Otherwise, a brief sentence about why you made these changes.

Content Checklist

Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.

Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 😸:

  • Break up walls of text by adding paragraph breaks.
  • Consider if the content could benefit from more structure, such as lists or tables, to make it easier to consume.
  • Keep the title between 20 and 70 characters.
  • Consider whether the content would benefit from more subsections (h2-h6 headings) to make it easier to consume.
  • Check all headings h1-h6 are in sentence case (only first letter is capitalized).
  • Is there a "Next steps" section at the end of the page giving the reader a clear path to what to read next?
  • Include relevant backlinks to other CircleCI docs/pages.

@BeFunes BeFunes requested review from a team as code owners November 27, 2024 09:49
@BeFunes BeFunes marked this pull request as draft November 27, 2024 09:49
@BeFunes BeFunes marked this pull request as ready for review November 27, 2024 11:09
@BeFunes
Copy link
Contributor Author

BeFunes commented Nov 27, 2024

@rosieyohannan not urgent, but something I'm wondering is if it's confusing to jam "trigger build" and "Trigger re-run via the CircleCI web app" into the "triggers" category.
Maybe a new header "Triggering builds" would make the distinction easier to grasp?

Screenshot 2024-11-27 at 12 13 18
Screenshot 2024-11-27 at 12 13 25

@BeFunes BeFunes merged commit c66c7a3 into master Nov 27, 2024
3 checks passed
@BeFunes BeFunes deleted the Benny-update-permission-matrix branch November 27, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants