Create mock ach bank account #101
Conversation
| <v-form> | ||
| <v-text-field | ||
| v-model="formData.account.accountNumber" | ||
| label="ACH Account Number" |
There was a problem hiding this comment.
should make this and following fields required
There was a problem hiding this comment.
I remember chatting with @kristinfritsch that we shouldn't be adding restriction/validation on UI?
There was a problem hiding this comment.
okay, not sure if we can enforce some rules in the class, also could at least do a hint (prompt xxx is required)
There was a problem hiding this comment.
The reason we don't want to put restrictions on the UI is to make testing of edge cases easier (e.g. error cases of the api). That doesn't really apply to mock apis. I think it's fine to make these fields required if needed.
There was a problem hiding this comment.
okie. Will update.
pages/debug/payouts/index.vue
Outdated
| <p> | ||
| <v-chip small color="primary warning">POST</v-chip> | ||
| <a href="/debug/ach/mocks/create"> | ||
| Create or update a mock ACH bank account |
There was a problem hiding this comment.
Does the mock endpoint support update?
There was a problem hiding this comment.
oh good catch. No update
| <v-form> | ||
| <v-text-field | ||
| v-model="formData.account.accountNumber" | ||
| label="ACH Account Number" |
There was a problem hiding this comment.
The reason we don't want to put restrictions on the UI is to make testing of edge cases easier (e.g. error cases of the api). That doesn't really apply to mock apis. I think it's fine to make these fields required if needed.
| /> | ||
|
|
||
| <v-btn | ||
| depressed |
There was a problem hiding this comment.
This button really should only be enabled for sandbox. E.g. we hide that button for on the mock wire page /debug/payments/mocks/wire. I don't think that's the best solution, but that's the pattern right now, so let's keep it.
…e make api call button on non mock env
New feature
Add support to create mock ACH bank account with specified balance and account numbuer/routing/description.
This endpoint will return a mock plaid processor token that can be use in circle sandbox to create an ach fiat account.
Payments APIs screen shot
Payouts APIs screen shot
@geehsien Per our discussion, I also bring in creating ach accounts to payouts API.
