Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing CustomerRefId From Cards API #15

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Removing CustomerRefId From Cards API #15

merged 3 commits into from
Mar 25, 2020

Conversation

tarunkumar2
Copy link
Contributor

The CustomerRefId param from the fetch cards API and add cards API has been removed. Reflecting the API change to the flow and APIs.

tsuikm
tsuikm reviewed Mar 24, 2020
View reviewed changes
lib/cardsApi.ts Outdated Show resolved Hide resolved
kristinfritsch
kristinfritsch requested changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@kristinfritsch kristinfritsch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove customerRefId from the cardTestData too.
Please also remove customerId everywhere (also from the GET /payments, GET /cards,...)

kristinfritsch
kristinfritsch approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@kristinfritsch kristinfritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kristinfritsch kristinfritsch merged commit 6dfda2b into circlefin:master Mar 25, 2020
@tarunkumar2 tarunkumar2 deleted the Remove-CusstomerRefId-From-Cards branch March 25, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phalski phalski phalski left review comments

@tsuikm tsuikm tsuikm left review comments

@kristinfritsch kristinfritsch kristinfritsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarunkumar2 @tsuikm @phalski @kristinfritsch