[NOTICKET] Explicitly send autoCapture in JSON request
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterXen
changed the title
autoCapture correctly in JSON requestautoCapture in JSON request
MasterXen
commented
Feb 16, 2022
| @@ -190,7 +190,7 @@ export default class CreatePaymentClass extends Vue { | |||
|
|
|||
| const payload: CreateMarketplaceCardPaymentPayload = { | |||
| idempotencyKey: uuidv4(), | |||
| autoCapture: this.formData.autoCapture ? undefined : false, | |||
There was a problem hiding this comment.
Simplify the logic to make this look correct to readers -- the current implementation is already correct since auto capture is the default but sending the true/false explicitly is clearer.
timmy-circle
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoCaptureis being coalesced toundefinedwhen being sent to the POST payload: https://developers.circle.com/reference#payments-payments-create.While
undefinedis allowed/correct from an API standpoint, the field is not documented in its behavior when not supplied and is confusing developers/readers. Instead, this PR makes the behavior more clear intrue/falsewhen submitting values.