Update Apple Pay in Staging #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiv0
commented
Mar 1, 2022
| event.validationURL, | ||
| (merchantSession: any): void => { | ||
| console.log('received session validation response') | ||
| console.log(merchantSession) |
There was a problem hiding this comment.
this is opaque object, just logging it to see if it is null or undefined
(apple pay js knows what to do with it, i just wanna see that it is not null)
antiv0
commented
Mar 1, 2022
| @@ -123,13 +130,16 @@ function handleApplePayEvents(appleSession: ApplePaySession) { | |||
| appleSession.onpaymentauthorized = function ( | |||
| event: ApplePayJS.ApplePayPaymentAuthorizedEvent | |||
| ) { | |||
| console.log('received authorization') | |||
| console.log(event.payment) | |||
| console.log(JSON.stringify(event.payment.token)) | |||
There was a problem hiding this comment.
// if this fails due to being null, that is also information - so i didn't add guards
This is most important part I want to see in console (is object so needs stringify)
jcantwell
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to logic which fixes bug in validation of session
added console logging which will be removed later but will help with debugging in staging