Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRAAV-9289] Make CVV Optional for 3DS #203

Merged
merged 2 commits into from
Mar 24, 2022
Merged

[BRAAV-9289] Make CVV Optional for 3DS #203

merged 2 commits into from
Mar 24, 2022

Conversation

Yves-liu
Copy link
Contributor

Summary:

Due to the current directional change, CVV is optional for 3DS.

Changes:

  1. Make CVV input line show up for 3DS.
  2. Change the CVV Input line label to "CVV Optional" for 3DS.
  3. If CVV input line is empty and the verification method is 3DS, will not try to encrypt the data.

Signed-off-by: yves.liu@circle.com <yves.liu@circle.com>
@@ -198,7 +208,11 @@ export default class CreatePaymentClass extends Vue {
}

try {
if (this.cvvRequired) {
Copy link
Contributor Author

@Yves-liu Yves-liu Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if statement looks really strange to me. But lint changed it for me. Lint throws error for any other format I can think of.

@huaweigu huaweigu merged commit f866145 into circlefin:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants