[BRAAV-11383] Dynamically populate blockchain dropdown #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaweigu
changed the title
…-sample-app into supported-currencies
huaweigu
reviewed
Jul 13, 2022
| @@ -86,17 +104,30 @@ export default class CreatePaymentIntentClass extends Vue { | |||
| expiresOn: '', | |||
| } | |||
|
|
|||
| currencyBlockchainPairs: CurrencyBlockchainPairs = | |||
| this.$cryptoPaymentMetadataApi.getSupportedCurrencyAndBlockchainCombinations() | |||
|
|
|||
| required = [(v: string) => !!v || 'Field is required'] | |||
| error = {} | |||
| loading = false | |||
| showError = false | |||
| supportedCurrencies = ['BTC', 'ETH', 'USD'] | |||
There was a problem hiding this comment.
Do we actually need to hardcode supportedCurrencies initially? It should be dynamically populated from the api response
There was a problem hiding this comment.
True - I will update this
There was a problem hiding this comment.
Updated in this commit: get currencies dynamically
huaweigu
approved these changes
Jul 15, 2022
| @@ -86,17 +104,33 @@ export default class CreatePaymentIntentClass extends Vue { | |||
| expiresOn: '', | |||
| } | |||
|
|
|||
| currencyBlockchainPairs: CurrencyBlockchainPairs = | |||
| this.$cryptoPaymentMetadataApi.getSupportedCurrencyAndBlockchainCombinations() | |||
There was a problem hiding this comment.
I this missing await?
There was a problem hiding this comment.
+1
@elizalucas could it be the bug?
There was a problem hiding this comment.
I think this has to do with it - I added this in this PR but still not fully solved yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dynamically populates the blockchain dropdown of the
POST /paymentintentsscreen based on an api output. The flow of the page is as follows:POST /paymentIntentspage, only the currency dropdown is visible