Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the get /beta/payouts screen #261

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

feirantonyhu
Copy link
Contributor

@feirantonyhu feirantonyhu commented Oct 20, 2022

As we renamed some of the query parameters at backend, we need to update the sample-app.

  • Replace destination type field with type (optional)
  • added status filter
  • crypto payout specific fields:
  • sourceCurrency
  • destinationCurrency
  • chain

Screen Shot 2022-10-20 at 2 36 14 PM

@@ -86,7 +90,11 @@ function getPayouts(
const queryParams = {
sourceWalletId: nullIfEmpty(sourceWalletId),
Copy link

@grantboicheff grantboicheff Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to source? It was changed recently. Or maybe it is already being sent as source under the hood? I'm not sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I have changed the name

@Yves-liu Yves-liu merged commit 125e2fb into circlefin:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants